Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quickProfile): improve quickProfile ui/ux #4975

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

josephmcg
Copy link
Contributor

What this PR does 📖

  • add click hander on Message avatar
  • improve overflow logic so it doesn't hug the edge of the screen
  • add click handlers and hover state on group chat sidebar

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@josephmcg josephmcg linked an issue Sep 22, 2022 that may be closed by this pull request
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 22, 2022
@josephmcg josephmcg changed the title fix(quickProfile): improve quickProfile ui/ux feat(quickProfile): improve quickProfile ui/ux Sep 22, 2022
@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Sep 22, 2022
@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Ready for QA Ready for QA team to test, Devs approved. labels Sep 22, 2022
@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed QA tested One QA Person has tested - Needs QA Lead review still labels Sep 22, 2022
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the username has some more chars, get cut off

Captura de ecrã 2022-09-22, às 19 33 56

also, if you try to message a user from the group chat that is not your friend, trying to send a message doesn't do anything

image

@phillsatellite
Copy link
Contributor

phillsatellite commented Sep 22, 2022

Just a quick question, are we going to add this and the rest of the group sidebar into mobile at a later time? Wasn't sure if this is intended just for Desktop. Thanks Joe!

RPReplay_Final1663872183.mp4

@josephmcg josephmcg force-pushed the 4965-quick-profile-styleux-improvements branch from b8aa892 to 065bff0 Compare September 26, 2022 00:08
@josephmcg
Copy link
Contributor Author

I fixed the overflow issue and removed the message input unless the user is your friend. Maybe we will add DM functionality for users that aren't friends eventually, but this seemed like the simplest fix for now.

I would like to add this as a third swiper slide on mobile, I'll make a ticket for that

@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Sep 26, 2022
@stavares843
Copy link
Member

thanks @josephmcg 🔨

@stavares843
Copy link
Member

Captura de ecrã 2022-09-26, às 13 48 14

made a group, all those are added as friends but clicking on any of them doesn't show the quick profile

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Sep 26, 2022
@josephmcg
Copy link
Contributor Author

I didnt touch that code. Did you restart nuxt after switching branches?

@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Sep 26, 2022
@stavares843
Copy link
Member

i used the fleek link 😂

@stavares843
Copy link
Member

which should be updated, unless both doesn't wanna work 😂

@stavares843 stavares843 merged commit 913ee5f into dev Sep 26, 2022
@stavares843 stavares843 deleted the 4965-quick-profile-styleux-improvements branch September 26, 2022 15:30
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quick profile style/ux improvements
4 participants